Add an ignore list to MixedNames #311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fourls
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Hi @EduardoVaz06, thanks for making this contribution! I agree with your reasoning and think it's definitely appropriate to include in the core rule behaviour.
Implementation looks great, no problems I can see. I have a couple of suggestions for some extra tests.
delphi-checks/src/test/java/au/com/integradev/delphi/checks/MixedNamesCheckTest.java
Show resolved
Hide resolved
delphi-checks/src/test/java/au/com/integradev/delphi/checks/MixedNamesCheckTest.java
Outdated
Show resolved
Hide resolved
delphi-checks/src/main/java/au/com/integradev/delphi/checks/MixedNamesCheck.java
Show resolved
Hide resolved
|
Hi @EduardoVaz06, this PR is a month old. |
Hi! Sorry for the huge delay. Soon i will make the changes requested and go on with de pr! |
cirras
force-pushed
the
AllowListToMixedNames
branch
from
c99a81f to
0577853
Compare
cirras
force-pushed
the
AllowListToMixedNames
branch
from
0577853 to
f27798a
Compare
cirras
merged commit 8fa8ce4
into
integrated-application-development:master
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setting on MixedNames rule to ignore certain names.
This PR implements a suggestion I have for MixedNames rule. In my company, we have certain patterns in names, so in some cases it's suggested by the rule to comply with the definition, and ends up not being compliant with our pattern. I think it would be good to have a list for names to be ignored.
For example, sometimes the rules suggest to be WParam, and sometimes WPARAM, due to the definition. If we have a pattern to always be WParam, this addition could help to ignore WParam name, and don't raise any issues.
It's up to you to know if this is a desired feature or not.